Steve wrote: >>>> 'My ebuild' is based upon the one in a sf bug [1] which is >>>> obviously based on he work on portage, which again is yours. IMHO >>>> the ebuild is far too complicated to maintain properly, >>>> >>> It's not that complicated. The whole pre-install configuration is >>> pretty logical. The post-install configuration is storage dependent >>> but the flow of the script is logical. >>> >> I've written some ebuilds and my share of shell scripts, and I disagree >> with you :) >> > Good! I like when people disagree. :) > So where and why do you disagree? What can we do better? What can we rip out? > What can we replace? How can we minimize the code without breaking it?
As I mentioned, I think we should rip out all the stuff that tries to do
the configuration. This holds for both the sed stuff during install, as
for the post-install script. IMHO we should ship an external utility
that does all this, and let the ebuild ship the stock configuration file.
The "USE flag to configure options" logic should ideally be the only
fancy code block in an ebuild. All the rest should ideally be resolved
'upstream', f.i. in dspams 'make install'. Since we're upstream,
submitting a patch upstream is trivial (writing it is something else).
This would f.i. mean to install helper sql scripts.
>> I'm no good with C or dialog,
>>
> Dialog is ultra easy. If you know Shell programming then dialog should not be
> an issue for you.
>
> A simple dialog for choosing the storage backend:
> ----
> dialog --backtitle "DSPAM storage backend" --radiolist "Select DSPAM storage
> backend to use:" 10 40 4 $(dsbc=0;for dsb in $(dspam --version|sed -n "s:,:
> :g;s:.*\-\with\-storage\-driver=\([^']*\)'.*:\1:gp");do let dsbc+=1;echo -ne
> ${dsbc} ${dsb} $([ ${dsbc} -eq 1 ] && echo "on" || echo "off")" ";done)
> ------
>
Looks easy enough, I'll give it a go :)
>>>> Maybe we can take the gentoo-specific talk off-list and try to get
>>>> something out that we can propose to gentoo devs for portage
>>>> inclusion. It would be nice to have beta4 as ~arch or ~arch-masked
>>>> in portage.
>>>>
>>> Alin Năstac is probably loaded with work. Maybe if we move to RC then
>>> he could include a Ebuild? I think if you would post an Ebuild in
>>> g.b.o then he would add it to Portage? Should I do it?
>>>
>> It seems that your connections are better than mine, so go ahead.
>> As said, I'll send you some more ebuild-related stuff off-list.
>>
> Okay. I am going to post the next BETA/RC release in b.g.o and push it to CVS.
>
Great :)
--
Regards,
Tom
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________ Dspam-user mailing list Dspam-user@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dspam-user
