Seb and others, I remembered that the doc you referenced mentions the LCNC repo on git hub. That made me think that using git hub may save reinventing the wheel here...
I'm thinking that "fork then pull request" is favorable over "push patch". Instead of developing patches against the repo in linuxcnc.org, we might want to encourage people to fork the git hub repo. Anyone can fork the github repo and then make a pull request. Then people contributing changes can make a pull request on github to get the change back into the LCNC github repo. This flow avoids some issues around who has push access etc to the repo on linuxcnc. Pull requests also get logged (so no need to invent patch submission tracking procedures), and a pull request invokes a code review process. The existing gut hub pull request review mechanism can be used to discuss and polish pull request changes. The github mechanisms also archive the review discussions. I think anyone can also look up the state of a pull request - so no need for a new volunteer to generate "patch status reports" etc. Doing "fork/pull request" vs "generating a patch against the Linuxcnc repo" lets us leverage the workflow tools git hub already provides - thus no need to invent new one off processes to track patches, comment about patches etc. When the patch is accepted into the git hub repo, a release manger can easily merge github back into the repo on LinuxCNC.org. Just thinking out load... it seems easier to me to leverage github than reinvent things. Dave On 1/8/2014 1:36 PM, Sebastian Kuzminsky wrote: > On 1/8/14 14:21 , Victor Rocco wrote: >> I am working to add some Modbus functions to mb2hal (Modbus to Hal, >> http://wiki.linuxcnc.org/cgi-bin/wiki.pl?ModbusToHal). >> Where should i submit the patch ? > I'm not Filipe, but I think this question is answered by the > "Contributing to LinuxCNC" document: > > http://www.linuxcnc.org/docs/html/code/Contributing-to-LinuxCNC.html > > Specifically the "Overview of the process" section. > > I think once a contributor follows that process, Filipe's work consists > of responding on the mailing list, helping the contributor with the > "champion your patch" work, and keeping track of the status of the patch > so it doesn't get forgotten. > > ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ Emc-developers mailing list Emc-developers@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/emc-developers
