Yedidyah Bar David has posted comments on this change. Change subject: First draft for engine-setup splitting ......................................................................
Patch Set 14: (3 comments) First batch - only looked at config/constants http://gerrit.ovirt.org/#/c/27647/14/packaging/setup/ovirt_engine_setup/config.py.in File packaging/setup/ovirt_engine_setup/config.py.in: Line 19 Line 20 Line 21 Line 22 Line 23 Perhaps rename? e.g. OVIRT_SETUP_CONFIG = '@OVIRT_SETUP_VARS@' (also in Makefile, constants etc) http://gerrit.ovirt.org/#/c/27647/14/packaging/setup/ovirt_engine_setup/constants.py File packaging/setup/ovirt_engine_setup/constants.py: Line 97 Line 98 Line 99 Line 100 Line 101 I think also these can be changed - 'ovirt-setup', 'ovirt-remove'. 'rename' should be moved to engine - there no general notion of rename. Perhaps better to have each app has some constant with its (very) short name and use that for such things - 'ovirt-$app-setup'. And BTW, I don't remember why we have the double prefix 'OVIRT_OVIRT_'. Might drop one of them now if we doing such a large change. Line 623 Line 624 Line 625 Line 626 Line 627 We might consider moving this to yet another new file, or simply to engineconstants and make other packages depend on it. Also all of EngineDBEnv. -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
