Simone Tiraboschi has posted comments on this change. Change subject: First draft for engine-setup splitting ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/27647/14/packaging/setup/plugins/ovirt-engine-common/base/db/connection.py File packaging/setup/plugins/ovirt-engine-common/base/db/connection.py: Line 34: from ovirt_engine_setup import constants as osetupcons Line 35: from ovirt_engine_setup import engineconstants as oenginecons Line 36: # TODO: ES: fix it, now it's under ovirt-engine-common Line 37: # the engine plugin could not be here Line 38: # move it to the engine plugin? > probably Engine itself, DWH and reports need a connection to the Engine DB and so this is probably shared code and in that case it's better to keep it under ovirt-engine-common if we want to avoid any code duplication between them. On the other side WebSocket Proxy doesn't need a connection to the Engine DB and so in that case we are adding a superfluous dependency just for simplicity. We can also split it under a new engine db related package having only the engine plugin, DWH plugin and reports plugin dependent from that but we need to be sure we want to handle some more packages cause probably also JBoss and apache related stuff require the same approach. Line 39: from ovirt_engine_setup import database Line 40: Line 41: Line 42: @util.export -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
