Simone Tiraboschi has posted comments on this change. Change subject: First draft for engine-setup splitting ......................................................................
Patch Set 14: (1 comment) http://gerrit.ovirt.org/#/c/27647/14/packaging/setup/ovirt_engine_setup/constants.py File packaging/setup/ovirt_engine_setup/constants.py: Line 623 Line 624 Line 625 Line 626 Line 627 > We might consider moving this to yet another new file, or simply to enginec What I want is indeed to avoid any DWH/Reports/WebSocketProxy -> Engine dependency cause we want to let the user install DWH without having the engine on the same host. Both DWH and reports need a connection to the Engine DB so I'm not sure we can move these to the engine specific file without introducing any code duplication. I renamed them just to make more clear that they are referring the engine DB. -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
