Simone Tiraboschi has posted comments on this change. Change subject: First draft for engine-setup splitting ......................................................................
Patch Set 14: (2 comments) http://gerrit.ovirt.org/#/c/27647/14/packaging/setup/ovirt_engine_setup/constants.py File packaging/setup/ovirt_engine_setup/constants.py: Line 623 Line 624 Line 625 Line 626 Line 627 > sure you need two constants, one for the engine and one for the common... : I agree that's the best strategy; these are for enginecommon constans file http://gerrit.ovirt.org/#/c/27647/14/packaging/setup/plugins/ovirt-engine-common/base/db/connection.py File packaging/setup/plugins/ovirt-engine-common/base/db/connection.py: Line 34: from ovirt_engine_setup import constants as osetupcons Line 35: from ovirt_engine_setup import engineconstants as oenginecons Line 36: # TODO: ES: fix it, now it's under ovirt-engine-common Line 37: # the engine plugin could not be here Line 38: # move it to the engine plugin? > websocket proxy and may be fence listener and future ca etc... are standalo Sorry, I didn't know about that division: I'm still quite new here :-) In that way everything makes more sense. Line 39: from ovirt_engine_setup import database Line 40: Line 41: Line 42: @util.export -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
