Sandro Bonazzola has posted comments on this change. Change subject: First draft for engine-setup splitting ......................................................................
Patch Set 14: (2 comments) Nice patch, looks goot to me for now. http://gerrit.ovirt.org/#/c/27647/14/packaging/setup/plugins/ovirt-engine-common/base/core/engine.py File packaging/setup/plugins/ovirt-engine-common/base/core/engine.py: Line 33: # to stop the engine installing or upgrading every other Line 34: # component; what should happen installing other components Line 35: # on different hosts? Line 36: # should we had the capability to stop the engine via a db Line 37: # signal from a remote host? we'll work on this while preparing the patches for running service on separate hosts. Line 38: from ovirt_engine_setup import dialog Line 39: Line 40: Line 41: @util.export http://gerrit.ovirt.org/#/c/27647/14/packaging/setup/plugins/ovirt-engine-common/base/db/connection.py File packaging/setup/plugins/ovirt-engine-common/base/db/connection.py: Line 34: from ovirt_engine_setup import constants as osetupcons Line 35: from ovirt_engine_setup import engineconstants as oenginecons Line 36: # TODO: ES: fix it, now it's under ovirt-engine-common Line 37: # the engine plugin could not be here Line 38: # move it to the engine plugin? probably Line 39: from ovirt_engine_setup import database Line 40: Line 41: Line 42: @util.export -- To view, visit http://gerrit.ovirt.org/27647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d465766f10a490bd213ca3510d02b3d6fdfa7c6 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
