Omer Frenkel has posted comments on this change.

Change subject: engine:Validate maximum number of hosts in DC.(#771699)
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

looks ok, something to think about:
this code also take in consideration hosts in maintenance, not sure if its good 
or not, is a maintenance host belongs to a pool? what if i have 250 hosts, and 
50 need some maintenance, but i want to join other 50 instead? this imaginary 
scenario would fail

--
To view, visit http://gerrit.ovirt.org/6514
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ef2ce160bc9ee4855b310c9d170ef7c14a0a17
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to