Ayal Baron has posted comments on this change.
Change subject: engine:Validate maximum number of hosts in DC.(#771699)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 296: &&
isNumberOfVdsInStoragePoolExceed(getVdsGroup().getstorage_pool_id().getValue()))
{
technically it's >= not =
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
Line 61: &&
isNumberOfVdsInStoragePoolExceed(getVdsGroup().getstorage_pool_id().getValue()))
{
If I'm moving host from cluster A to cluster B within the same DC then the
operation should succeed as the host already has a host id assigned to it.
So you should first check that DC ID is not the same and only then verify
number of hosts.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java
Line 196: .size() + 1);
so what's protecting us from doing 2 simultaneous actions (2 users either
adding a new host or moving hosts between DCs)?
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 590:
ACTION_TYPE_FAILED_EXCEEDED_MAXIMUM_NUMBER_OF_HOSTS_IN_DATA_CENTER=Can not
${action} ${type}. The maximum number of Hosts allowed in Data Center has been
exceeded.
s/Hosts/hosts/
s/Data Center/data center/
....................................................
Commit Message
Line 12: If the number of hosts has exceeded the user should be presented with
an
s/If.*presented/If max number of hosts is exceeded, user should be presented/
--
To view, visit http://gerrit.ovirt.org/6514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ef2ce160bc9ee4855b310c9d170ef7c14a0a17
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
