Allon Mureinik has posted comments on this change.
Change subject: engine:Validate maximum number of hosts in DC.(#771699)
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 296: &&
isNumberOfVdsInStoragePoolExceed(getVdsGroup().getstorage_pool_id().getValue()))
{
The method is called blablaExceed() - can you clarify your comment?
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 590:
ACTION_TYPE_FAILED_EXCEEDED_MAXIMUM_NUMBER_OF_HOSTS_IN_DATA_CENTER=Can not
${action} ${type}. The maximum number of Hosts allowed in Data Center has been
exceeded.
Ayal - oVirt entities (e.g., Host, Data Center, Cluster) are referenced with a
capital letter.
Lets keep this convention, and if we decide to fix it in a later patch, let's
do it for the ENTIRE file.
Line 590:
ACTION_TYPE_FAILED_EXCEEDED_MAXIMUM_NUMBER_OF_HOSTS_IN_DATA_CENTER=Can not
${action} ${type}. The maximum number of Hosts allowed in Data Center has been
exceeded.
arg - s/be/we, of course.
--
To view, visit http://gerrit.ovirt.org/6514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ef2ce160bc9ee4855b310c9d170ef7c14a0a17
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
