Maor Lipchuk has posted comments on this change. Change subject: engine:Validate maximum number of hosts in DC.(#771699) ......................................................................
Patch Set 1: It is not the code lines that bother me, its the issue that I don't want to propagate our DB with stored procedures for each minor validation in a way that it will be hard to maintain, so considering that I think fetching the hosts will not be that bad alternative. Regarding the race I thought using the lockId for the command, but if you already implementing a better solution I will wait for it. -- To view, visit http://gerrit.ovirt.org/6514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1ef2ce160bc9ee4855b310c9d170ef7c14a0a17 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
