Maor Lipchuk has posted comments on this change.
Change subject: engine:Validate maximum number of hosts in DC.(#771699)
......................................................................
Patch Set 1: (10 inline comments)
I first thought maybe change the validation to count only active hosts, until I
saw in the bug, that the problem is only the host id that we generate to the
host in the beginning.
Checking if it can be solved in the VDSM instead, and indeed use that
configuration only for non-maintenance hosts.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java
Line 296: &&
isNumberOfVdsInStoragePoolExceed(getVdsGroup().getstorage_pool_id().getValue()))
{
next patch should be called isNumberOfVdsExceeded.
and I also not sure I understood your comment , can you please elaborate.
Line 298: returnValue = false;
agreed, will be in another patch later.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
Line 61: &&
isNumberOfVdsInStoragePoolExceed(getVdsGroup().getstorage_pool_id().getValue()))
{
agreed, will change.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsCommand.java
Line 194: protected boolean isNumberOfVdsInStoragePoolExceed(Guid
storagePoolId) {
Done
Line 196: .size() + 1);
It is a race that also Kublin mentioned, should be fixed next resent
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 590:
ACTION_TYPE_FAILED_EXCEEDED_MAXIMUM_NUMBER_OF_HOSTS_IN_DATA_CENTER=Can not
${action} ${type}. The maximum number of Hosts allowed in Data Center has been
exceeded.
Done
Line 590:
ACTION_TYPE_FAILED_EXCEEDED_MAXIMUM_NUMBER_OF_HOSTS_IN_DATA_CENTER=Can not
${action} ${type}. The maximum number of Hosts allowed in Data Center has been
exceeded.
I agree with Allon regarding that, all entities should start with upper case
letter (PM decision)
....................................................
Commit Message
Line 8:
Done
Line 9: When user add a host, there should be a check whether the maximum
number of
Done
Line 12: If the number of hosts has exceeded the user should be presented with
an
Done.
--
To view, visit http://gerrit.ovirt.org/6514
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1ef2ce160bc9ee4855b310c9d170ef7c14a0a17
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
