Yair Zaslavsky has posted comments on this change.
Change subject: Adding bios information to vds object
......................................................................
Patch Set 13: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 524: new VdsIdAndVdsVDSCommandParametersBase(vds));
Line 525: vdsBrokerCommand.Execute();
Line 526: if (vdsBrokerCommand.getVDSReturnValue().getSucceeded()) {
Line 527: // Verify if version is upper then 3.2 for bios
capabilities
Line 528: if
(vds.getSupportedClusterVersionsSet().contains(Version.v3_2)){
Correct.
Yaniv, please look at Config values containing the suffix Enabled - they define
if a feature is enabled or not.
Line 529: GetBiosInfoVDSCommand vdsBiosCommand = new
GetBiosInfoVDSCommand(
Line 530: new VdsIdAndVdsVDSCommandParametersBase(vds));
Line 531: vdsBiosCommand.Execute();
Line 532: if
(!vdsBrokerCommand.getVDSReturnValue().getSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
