Yair Zaslavsky has posted comments on this change. Change subject: Adding bios information to vds object ......................................................................
Patch Set 13: I would prefer that you didn't submit this (2 inline comments) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java Line 155: } else if (!vds_group_nameField.equals(other.vds_group_nameField)) Line 156: return false; Line 157: return true; Line 158: } Line 159: Missing fields at hashCode and equals methods. Please take care Line 160: public VDS(Guid vds_group_id, String vds_group_name, String vds_group_description, Guid vds_id, String vds_name, Line 161: String ip, String host_name, int port, int status, String biosManufacturer, String biosProductName, Line 162: String biosVersion, String biosSerialNumber, String biosUUID, String biosFamily, Line 163: Integer cpu_cores, String cpu_model, .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java Line 122: private ValueObjectMap pmOptionsMap; Line 123: Line 124: @Column(name = "otp_validity") Line 125: private long otpValidity; Line 126: Missing treatment at hashcode and equals, please take care. Line 127: @Min(BusinessEntitiesDefinitions.HOST_MIN_SPM_PRIORITY) Line 128: @Max(BusinessEntitiesDefinitions.HOST_MAX_SPM_PRIORITY) Line 129: @Column(name = "vds_spm_priority") Line 130: private int vdsSpmPriority; -- To view, visit http://gerrit.ovirt.org/9337 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Michael Pasternak <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
