Yaniv Bronhaim has posted comments on this change.
Change subject: Adding bios information to vds object
......................................................................
Patch Set 13: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDS.java
Line 42: result = prime * result + ((mImagesLastCheck == null) ? 0 :
mImagesLastCheck.hashCode());
Line 43: result = prime * result + ((mImagesLastDelay == null) ? 0 :
mImagesLastDelay.hashCode());
Line 44: result = prime * result + ((mInterfaceList == null) ? 0 :
mInterfaceList.hashCode());
Line 45: result = prime * result + ((mNetworkList == null) ? 0 :
mNetworkList.hashCode());
Line 46: result = prime * result + ((mVdsDynamic == null) ? 0 :
mVdsDynamic.hashCode());
look here and read next comment :)
Line 47: result = prime * result + ((mVdsStatic == null) ? 0 :
mVdsStatic.hashCode());
Line 48: result = prime * result + ((mVdsStatistics == null) ? 0 :
mVdsStatistics.hashCode());
Line 49: result = prime * result + max_vds_memory_over_commitField;
Line 50: result = prime * result + ((privateDomains == null) ? 0 :
privateDomains.hashCode());
Line 106: } else if (!mNetworkList.equals(other.mNetworkList))
Line 107: return false;
Line 108: if (mVdsStatic == null) {
Line 109: if (other.mVdsStatic != null)
Line 110: return false;
no! they are declared in vdsStatic and vds.hashCode calls that
Line 111: } else if (!mVdsStatic.equals(other.mVdsStatic))
Line 112: return false;
Line 113: if (max_vds_memory_over_commitField !=
other.max_vds_memory_over_commitField)
Line 114: return false;
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java
Line 500: result = prime * result + ((uniqueId == null) ? 0 :
uniqueId.hashCode());
Line 501: result = prime * result + ((vdsGroupId == null) ? 0 :
vdsGroupId.hashCode());
Line 502: result = prime * result + ((vdsStrength == null) ? 0 :
vdsStrength.hashCode());
Line 503: result = prime * result + ((vdsType == null) ? 0 :
vdsType.hashCode());
Line 504: result = prime * result + ((biosManufacturer == null) ? 0 :
biosManufacturer.hashCode());
?
Line 505: result = prime * result + ((biosProductName == null) ? 0 :
biosProductName.hashCode());
Line 506: result = prime * result + ((biosVersion == null) ? 0 :
biosVersion.hashCode());
Line 507: result = prime * result + ((biosSerialNumber == null) ? 0 :
biosSerialNumber.hashCode());
Line 508: result = prime * result + ((biosUUID == null) ? 0 :
biosUUID.hashCode());
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
