Allon Mureinik has posted comments on this change.
Change subject: Adding bios information to vds object
......................................................................
Patch Set 13: (3 inline comments)
some minor issues.
Also, please address Yair and Omer's comments
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java
Line 304:
Line 305: private boolean registerNewHost(Guid vdsGroupId, boolean
IsPending) {
Line 306: boolean returnValue = true;
Line 307: // management ip is not currently passed by registration
Line 308: VdsStatic vds = new
VdsStatic(getParameters().getVdsHostName(), "",
Not that I'm against this change - but it has nothing to do with this patch.
please perform it in a separate cleanup.
Line 309: getStrippedVdsUniqueId(),
getParameters().getPort(), vdsGroupId, Guid.Empty,
Line 310: getParameters().getVdsName(), Config.<Boolean>
GetValue(ConfigValues.SSLEnabled),
Line 311: getParameters().getVdsType());
Line 312:
....................................................
File backend/manager/modules/dal/src/test/resources/fixtures.xml
Line 4232: </row>
Line 4233: <row>
Line 4234: <value>vds</value>
Line 4235: <value>sshkeyfingerprint</value>
Line 4236: </row>
This change is unrelate to the patch
Line 4237: </table>
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
Line 524: new VdsIdAndVdsVDSCommandParametersBase(vds));
Line 525: vdsBrokerCommand.Execute();
Line 526: if (vdsBrokerCommand.getVDSReturnValue().getSucceeded()) {
Line 527: // Verify if version is upper then 3.2 for bios
capabilities
Line 528: if
(vds.getSupportedClusterVersionsSet().contains(Version.v3_2)){
This should be done with a ConfigValue, not by directly comparing the version
Line 529: GetBiosInfoVDSCommand vdsBiosCommand = new
GetBiosInfoVDSCommand(
Line 530: new VdsIdAndVdsVDSCommandParametersBase(vds));
Line 531: vdsBiosCommand.Execute();
Line 532: if
(!vdsBrokerCommand.getVDSReturnValue().getSucceeded()) {
--
To view, visit http://gerrit.ovirt.org/9337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8582b
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
