Alon Bar-Lev has posted comments on this change.
Change subject: DO NOT MERGE: packaging: engine-setup - add firewalld support
......................................................................
Patch Set 1: (4 inline comments)
....................................................
File packaging/fedora/setup/engine-setup.py
Line 164: { 'description' : 'Final Steps',
Line 165: 'condition' : [],
Line 166: 'condition_match' : [],
Line 167: 'steps' : [ { 'title' :
output_messages.INFO_CFG_IPTABLES,
Line 168: 'functions' :
[_configFirewalld] },
This means we do not support fedora-17 any more, which I against of doing as
there is no reason.
Line 169: { 'title' :
output_messages.INFO_START_ENGINE,
Line 170: 'functions' :
[_startEngine] } ]
Line 171: },
Line 172: { 'description' : 'Handling httpd',
Line 886: def _configFirewalld():
Line 887: logging.debug("configuring firewalld")
Line 888:
Line 889: # Open xml
Line 890: servicexml =
utils.XMLConfigFileHandler(basedefs.FILE_FIREWALLD_SERVICE)
space
Line 891: servicexml.open()
Line 892:
Line 893: # Remove all port entries
Line 894: servicexml.removeNodes("/service/ports")
Line 918:
Line 919: # Restart firewalld
Line 920: service = utils.Service("firewalld")
Line 921: service.stop(True)
Line 922: service.start(True)
Must be a better way to reload.
Line 923: else:
Line 924: pass
Line 925: # print MSG about how to add needed ports
Line 926:
....................................................
File packaging/fedora/setup/firewalld.ovirt.xml
Line 1: <?xml version="1.0" encoding="utf-8"?>
Line 2: <service>
Line 3: <short>ovirt</short>
Line 4: <description>UberPortOfDoon</description>
Not nice description.
I don't think we need the 8080.
What is 8111?
Line 5: <port protocol="udp" port="8080"/>
Line 6: <port protocol="tcp" port="8080"/>
Line 7: <port protocol="tcp" port="8111"/>
--
To view, visit http://gerrit.ovirt.org/10493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieea93c90ffb90e02b880949a67575495aac5a472
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
