Alon Bar-Lev has posted comments on this change.
Change subject: packaging: engine-setup - add firewalld support
......................................................................
Patch Set 9: (2 inline comments)
Two minor questions... :)
....................................................
File packaging/fedora/setup/engine-setup.py
Line 950: service = utils.Service("firewalld")
Line 951: service.start(True)
Line 952:
Line 953: for zone in firewalld.getActiveZones():
Line 954: firewalld.addServiceToZone("ovirt", zone)
Can I understand that without this, even if the file exists it won't be active?
Line 955:
Line 956: # Restart firewalld
Line 957: service = utils.Service("firewalld")
Line 958: service.stop(True)
....................................................
File packaging/fedora/setup/output_messages.py
Line 86: INFO_DB_RESTORED="Database upgrade failed. Previous database has been
restored"
Line 87:
Line 88: #config ip tables
Line 89: INFO_IPTABLES_FILE="an example of the required configuration for
iptables can be found at: %s"
Line 90: INFO_FIREWALLD_FILE="an example of the required configuration for
firewalld can be found at: %s"
Or if I understand correct:
for firewalld add the ovirt service
???
Line 91: # the last 2 ports are http & https entered by the user
Line 92: INFO_IPTABLES_PORTS=basedefs.APP_NAME + " requires the following
TCP/IP Incoming ports to be opened on the firewall:\n\
Line 93: 22, %s, %s "
Line 94: INFO_IPTABLES_BACKUP_FILE="The firewall has been updated, the old
iptables configuration file was saved to %s"
--
To view, visit http://gerrit.ovirt.org/10493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieea93c90ffb90e02b880949a67575495aac5a472
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
