Juan Hernandez has posted comments on this change.
Change subject: packaging: engine-setup - add firewalld support
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 772: %{engine_data}/scripts/post_upgrade.py*
Line 773: %{engine_data}/scripts/add_fn_db_get_async_tasks_function.sql
Line 774:
Line 775: # Firewalld configuration
Line 776: %{_sysconfdir}/firewalld/services/ovirt.xml
Shouldn't this be %config(noreplace)?
Line 777:
Line 778: # Man pages
Line 779: %{_mandir}/man8/engine-setup.*
Line 780: %{_mandir}/man8/engine-upgrade.*
--
To view, visit http://gerrit.ovirt.org/10493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieea93c90ffb90e02b880949a67575495aac5a472
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
