Alon Bar-Lev has posted comments on this change.
Change subject: DO NOT MERGE: packaging: engine-setup - add firewalld support
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File packaging/fedora/setup/engine-setup.py
Line 164: { 'description' : 'Final Steps',
Line 165: 'condition' : [],
Line 166: 'condition_match' : [],
Line 167: 'steps' : [ { 'title' :
output_messages.INFO_CFG_IPTABLES,
Line 168: 'functions' :
[_configFirewalld] },
No... if firewalld installed.
But as user may still use iptables, yes, user may chose to use one technology,
maybe best to simply ask, while firewalld is the default if installed or even
available.
Line 169: { 'title' :
output_messages.INFO_START_ENGINE,
Line 170: 'functions' :
[_startEngine] } ]
Line 171: },
Line 172: { 'description' : 'Handling httpd',
--
To view, visit http://gerrit.ovirt.org/10493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieea93c90ffb90e02b880949a67575495aac5a472
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
