Ofer Schreiber has posted comments on this change.
Change subject: packaging: engine-setup - add firewalld support
......................................................................
Patch Set 6: (4 inline comments)
....................................................
File packaging/fedora/setup/common_utils.py
Line 1250:
Line 1251: def available(self):
Line 1252: logging.debug("checking if %s service is available",
self.name)
Line 1253: out, rc = self.status()
Line 1254: return (not (rc != 0 and ("No such file or directory" in out
or "unrecognized service" in out)))
systemctl isn't available in rhel afaik
Line 1255:
Line 1256: def chown(target,uid, gid):
Line 1257: logging.debug("chown %s to %s:%s" % (target, uid, gid))
Line 1258: os.chown(target, uid, gid)
....................................................
File packaging/fedora/setup/engine_firewalld.py
Line 1: from gi.repository import GObject
Line 2: import sys
Line 3: sys.modules['gobject'] = GObject
iirc, something in firewalld required it. I'll recheck
Line 4: from firewall.client import FirewallClient
Line 5: from firewall.errors import *
Line 6:
Line 7: def getActiveZones():
....................................................
File packaging/fedora/setup/engine-setup.py
Line 888:
Line 889: if iptables.available():
Line 890: logging.debug("iptables service found")
Line 891: _configIptables()
Line 892: elif fwd.available():
firewalld indeed should be higher.
I'm against asking the user. it makes the "asking" code much complex.
Line 893: logging.debug("firewalld service found")
Line 894: _configFirewalld()
Line 895: elif controller.CONF["OVERRIDE_IPTABLES"] == "yes":
Line 896: raise Exception(output_messages.ERR_CANT_FIND_FIREWALL)
....................................................
File packaging/fedora/spec/ovirt-engine.spec.in
Line 772: %{engine_data}/scripts/post_upgrade.py*
Line 773: %{engine_data}/scripts/add_fn_db_get_async_tasks_function.sql
Line 774:
Line 775: # Firewalld configuration
Line 776: %{_sysconfdir}/firewalld/services/ovirt.xml
indeed
Line 777:
Line 778: # Man pages
Line 779: %{_mandir}/man8/engine-setup.*
Line 780: %{_mandir}/man8/engine-upgrade.*
--
To view, visit http://gerrit.ovirt.org/10493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieea93c90ffb90e02b880949a67575495aac5a472
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
