Alona Kaplan has posted comments on this change.
Change subject: webadmin: Add details to general Cluster sub-tab
......................................................................
Patch Set 3: (5 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java
Line 41: @Override
Line 42: public void update() {
Line 43: super.update();
Line 44:
Line 45: TextBoxLabel cpuThreads = new TextBoxLabel();
cpuThreads should be a data member and defined as BooleanLabel.
BooleanLabel cpuThreads = new BooleanLabel(constants.yes(), constants.no());
Line 46: cpuThreads.setText(getModel().isCpuThreads() ? constants.yes()
: constants.no());
Line 47:
Line 48: TextBoxLabel resiliencePolicy = new TextBoxLabel();
Line 49: switch (getModel().getResiliencePolicy()) {
Line 44:
Line 45: TextBoxLabel cpuThreads = new TextBoxLabel();
Line 46: cpuThreads.setText(getModel().isCpuThreads() ? constants.yes()
: constants.no());
Line 47:
Line 48: TextBoxLabel resiliencePolicy = new TextBoxLabel();
resiliencePolicy should be a data member.
You can create a ResiliencePolicyLabel (see MemorySizeLabel for example).
Line 49: switch (getModel().getResiliencePolicy()) {
Line 50: case YES:
Line 51: resiliencePolicy.setText(constants.yes());
Line 52: break;
Line 57: resiliencePolicy.setText(constants.highPriorityOnly());
Line 58: break;
Line 59: }
Line 60:
Line 61: TextBoxLabel memoryOverCommit = new TextBoxLabel();
Same- memoryOverCommit shouldn't be defined here, it should be a data member.
Line 62:
memoryOverCommit.setText(String.valueOf(getModel().getMemoryOverCommit()));
Line 63:
Line 64: formBuilder.setColumnsWidth("240px", "160px"); //$NON-NLS-1$
//$NON-NLS-2$
Line 65: formBuilder.addFormItem(new FormItem(constants.nameCluster(),
name, 0, 0));
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.ui.xml
Line 73: }
Line 74: </ui:style>
Line 75: <g:DockLayoutPanel height="100%">
Line 76: <g:west size="570">
Line 77: <g:FlowPanel addStyleNames="{style.leftPanel}">
Fix the indentation.
Line 78: <g:HorizontalPanel spacing="5">
Line 79: <g:HorizontalPanel ui:field="policyPanel"
addStyleNames="{style.marginLeft}">
Line 80: <g:FlowPanel width="400px">
Line 81: <w:UiCommandButton
ui:field="editPolicyButton" addStyleNames="{style.button}" />
Line 123: <c:ClusterGeneralModelForm ui:field="form" />
Line 124: </g:center>
Line 125: </g:DockLayoutPanel>
Line 126: </ui:UiBinder>
Line 127:
remove trailing white spaces.
--
To view, visit http://gerrit.ovirt.org/11726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9933cd4ec03a3df35dc4ff8fa157854b776a632c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
