Kanagaraj M has posted comments on this change.
Change subject: webadmin: Add details to general Cluster sub-tab
......................................................................
Patch Set 5: (4 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java
Line 14: import com.google.gwt.editor.client.SimpleBeanEditorDriver;
Line 15:
Line 16: public class ClusterGeneralModelForm extends
AbstractModelBoundFormWidget<ClusterGeneralModel> {
Line 17:
Line 18: private static CommonApplicationConstants constants =
GWT.create(CommonApplicationConstants.class);
No need to initialize here, as this is passed as constructor argument you can
assign to this.
Line 19:
Line 20: interface Driver extends
SimpleBeanEditorDriver<ClusterGeneralModel, ClusterGeneralModelForm> {
Line 21: Driver driver = GWT.create(Driver.class);
Line 22: }
Line 30: ResiliencePolicyLabel resiliencePolicy = new
ResiliencePolicyLabel(constants);
Line 31:
Line 32:
Line 33: public ClusterGeneralModelForm(ModelProvider<ClusterGeneralModel>
modelProvider, CommonApplicationConstants constants) {
Line 34: super(modelProvider, 2, 7);
you may need 4 rows but not 7.
Line 35:
Line 36: Driver.driver.initialize(this);
Line 37:
Line 38: formBuilder.setColumnsWidth("240px", "160px"); //$NON-NLS-1$
//$NON-NLS-2$
Line 41: formBuilder.addFormItem(new
FormItem(constants.nameStoragePool(), dataCenterName, 2, 0));
Line 42: formBuilder.addFormItem(new
FormItem(constants.cpuNameCluster(), cpuName, 3, 0));
Line 43: formBuilder.addFormItem(new
FormItem(constants.cpuThreadsCluster(), cpuThreads, 0, 1));
Line 44: formBuilder.addFormItem(new
FormItem(constants.memoryOptimizationCluster(), memoryOverCommit, 1,1));
Line 45: formBuilder.addFormItem(new
FormItem(constants.resiliencePolicyCluster(), resiliencePolicy, 2, 1));
Please show the last 4 fields(cpuName, cpuThreads, memoryOverCommit,
resiliencePolicy) only if the cluster supports virt service.
Line 46: }
Line 47:
Line 48: @Override
Line 49: protected void doEdit(ClusterGeneralModel model) {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.ui.xml
Line 121: </g:HTMLPanel>
Line 122: </g:FlowPanel>
Line 123: </g:west>
Line 124: <g:center size="300">
Line 125: <c:ClusterGeneralModelForm ui:field="form"/>
Half of the volumeSummaryPanel is hidden. Please create a cluster with both
Virt and Gluster services enabled and verify this.
Also we have an alerts panel in the bottom, please make sure the formPanel is
not colliding with it.
Line 126: </g:center>
Line 127: </g:DockLayoutPanel>
--
To view, visit http://gerrit.ovirt.org/11726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9933cd4ec03a3df35dc4ff8fa157854b776a632c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
