Kanagaraj M has posted comments on this change.
Change subject: webadmin: Add details to general Cluster sub-tab
......................................................................
Patch Set 6: Looks good to me, but someone else must approve
(2 inline comments)
some minor comments.
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/GeneralFormPanel.ui.xml
Line 35: font-family: Arial,sans-serif;
Line 36: color: #777777;
Line 37: padding-left: 4px;
Line 38: padding-top: 4px;
Line 39: padding-bottom: 4px;
Please fix the indentation.
Line 40: }
Line 41:
Line 42: @external formPanel_viewerNamesColumn;
Line 43: .formPanel_viewerNamesColumn {
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java
Line 88: @Override
Line 89: public boolean isVisible() {
Line 90: return getModel().getEntity().supportsGlusterService();
Line 91: }
Line 92: });
Please change the label of them above 3 items in ApplicationConstants. "No. Of
Volumes" ==> "Total No. of Volumes", "Up" ==> "No. of Volumes Up", "Down" ==>
"No. of Volumes Down".
Line 93: }
Line 94:
Line 95: @Override
Line 96: protected void doEdit(ClusterGeneralModel model) {
--
To view, visit http://gerrit.ovirt.org/11726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9933cd4ec03a3df35dc4ff8fa157854b776a632c
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
