Alona Kaplan has posted comments on this change.
Change subject: webadmin: Add details to general Cluster sub-tab
......................................................................
Patch Set 8: (6 inline comments)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/GeneralFormPanel.ui.xml
Line 31:
Line 32: @external formPanel_itemValue;
Line 33: .formPanel_itemValue {
Line 34: white-space: nowrap;
Line 35: font-family: Arial,sans-serif;
Please remove trailing white space.
Line 36: color: #777777;
Line 37: padding-left: 4px;
Line 38: padding-top: 4px;
Line 39: padding-bottom: 4px;
Line 37: padding-left: 4px;
Line 38: padding-top: 4px;
Line 39: padding-bottom: 4px;
Line 40: }
Line 41:
Same.
Line 42: @external formPanel_viewerNamesColumn;
Line 43: .formPanel_viewerNamesColumn {
Line 44: }
Line 45:
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/ResiliencePolicyLabel.java
Line 26: }
Line 27: }
Line 28:
Line 29: @Override
Line 30: public void render(MigrateOnErrorOptions
migrateOnErrorOptions, Appendable appendable) throws IOException {
why do you need this?
Line 31: appendable.append(render(migrateOnErrorOptions));
Line 32: }
Line 33:
Line 34: });
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/ClusterTypeRendere.java
Line 5:
Line 6: import java.io.IOException;
Line 7:
Line 8: public class ClusterTypeRendere {
Line 9: class ClusterTypeRenderer implements
Renderer<ClusterTypeLabel.ClusterType> {
I don't understand this declaration.
Line 10:
Line 11: @Override
Line 12: public String render(ClusterTypeLabel.ClusterType object) {
Line 13: return null; //To change body of implemented methods use
File | Settings | File Templates.
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/renderer/ClusterTypeRenderer.java
Line 28: }
Line 29: }
Line 30:
Line 31: @Override
Line 32: public void render(ClusterGeneralModel.ClusterType object,
Appendable appendable) throws IOException {
why do you need this?
Line 33: appendable.append(render(object));
Line 34: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java
Line 54:
Line 55: // properties for virt support
Line 56: formBuilder.addFormItem(new
FormItem(constants.cpuNameCluster(), cpuName, 0, 1) {
Line 57: @Override
Line 58: public Widget getValue() {
Instead of using anonymous classes in all the following form items, you can
declare LabelWithDefaultValue(IsDefault condition, String defaultValue)
interface IsDefault{
boolean isDefault();
}
Line 59: return getModel().getEntity().supportsVirtService() ?
cpuName
Line 60: : new
TextBoxLabel(constants.notAvailableLabel());
Line 61: }
Line 62: });
--
To view, visit http://gerrit.ovirt.org/11726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9933cd4ec03a3df35dc4ff8fa157854b776a632c
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
