ofri masad has posted comments on this change.

Change subject: webadmin: Add details to general Cluster sub-tab
......................................................................


Patch Set 5: (5 inline comments)

....................................................
File 
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/GeneralFormPanel.ui.xml
Line 34:                        white-space: nowrap;
Line 35:                        font-family: Arial,sans-serif;          
Line 36:                        color: #777777;
Line 37:                        padding-left: 4px;
Line 38:                padding-top: 4px;
Done
Line 39:                    padding-bottom: 4px;
Line 40:                }
Line 41:                
Line 42:                @external formPanel_viewerNamesColumn;


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/ClusterGeneralModelForm.java
Line 14: import com.google.gwt.editor.client.SimpleBeanEditorDriver;
Line 15: 
Line 16: public class ClusterGeneralModelForm extends 
AbstractModelBoundFormWidget<ClusterGeneralModel> {
Line 17: 
Line 18:     private static CommonApplicationConstants constants = 
GWT.create(CommonApplicationConstants.class);
Done
Line 19: 
Line 20:     interface Driver extends 
SimpleBeanEditorDriver<ClusterGeneralModel, ClusterGeneralModelForm> {
Line 21:         Driver driver = GWT.create(Driver.class);
Line 22:     }


Line 30:     ResiliencePolicyLabel resiliencePolicy = new 
ResiliencePolicyLabel(constants);
Line 31: 
Line 32: 
Line 33:     public ClusterGeneralModelForm(ModelProvider<ClusterGeneralModel> 
modelProvider, CommonApplicationConstants constants) {
Line 34:         super(modelProvider, 2, 7);
Done
Line 35: 
Line 36:         Driver.driver.initialize(this);
Line 37: 
Line 38:         formBuilder.setColumnsWidth("240px", "160px"); //$NON-NLS-1$ 
//$NON-NLS-2$


Line 41:         formBuilder.addFormItem(new 
FormItem(constants.nameStoragePool(), dataCenterName, 2, 0));
Line 42:         formBuilder.addFormItem(new 
FormItem(constants.cpuNameCluster(), cpuName, 3, 0));
Line 43:         formBuilder.addFormItem(new 
FormItem(constants.cpuThreadsCluster(), cpuThreads, 0, 1));
Line 44:         formBuilder.addFormItem(new 
FormItem(constants.memoryOptimizationCluster(), memoryOverCommit, 1,1));
Line 45:         formBuilder.addFormItem(new 
FormItem(constants.resiliencePolicyCluster(), resiliencePolicy, 2, 1));
Done
Line 46:     }
Line 47: 
Line 48:     @Override
Line 49:     protected void doEdit(ClusterGeneralModel model) {


....................................................
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterGeneralView.ui.xml
Line 121:                               </g:HTMLPanel>
Line 122:                       </g:FlowPanel>
Line 123:               </g:west>
Line 124:               <g:center size="300">
Line 125:                       <c:ClusterGeneralModelForm ui:field="form"/>
Done
Line 126:               </g:center>
Line 127:       </g:DockLayoutPanel>


--
To view, visit http://gerrit.ovirt.org/11726
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9933cd4ec03a3df35dc4ff8fa157854b776a632c
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to