Alissa Bonas has posted comments on this change. Change subject: core,restapi,webadmin: Added description field to storage domain ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByImageIdQueryTest.java Line 65: 0, Line 66: StorageDomainStatus.Active, Line 67: "StoragePoolName", Line 68: 0, Line 69: 0, "Second Storage Description"); I would add a test with a long description to test the max length validation Line 70: List<storage_domains> expected = new ArrayList<storage_domains>(); Line 71: expected.add(firstStorageDomain); Line 72: expected.add(secondStorageDomain); Line 73: -- To view, visit http://gerrit.ovirt.org/11929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86bcd7c52e5d9cad7c3cb30561718203537ab459 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
