Maor Lipchuk has posted comments on this change.
Change subject: core,restapi,webadmin: Added description field to storage domain
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java
Line 23: @ValidName(message =
"VALIDATION.STORAGE_DOMAIN.DESCRIPTION.INVALID", groups = { CreateEntity.class,
Line 24: UpdateEntity.class })
Line 25: @Size(min = 1, max =
BusinessEntitiesDefinitions.CLUSTER_NAME_SIZE, message =
"VALIDATION.VDS_GROUP.NAME.MAX",
Line 26: groups = { CreateEntity.class, UpdateEntity.class })
Line 27: private String description;
CLUSTER_NAME_SIZE is not good, it's 40 characters and not related to the field,
you simply need to use what I was written in the last comment.
message not related also.
Line 28:
Line 29: private StorageDomainType storageType = StorageDomainType.Master;
Line 30:
Line 31: private StorageType storagePoolType = StorageType.UNKNOWN;
--
To view, visit http://gerrit.ovirt.org/11929
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86bcd7c52e5d9cad7c3cb30561718203537ab459
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
