Allon Mureinik has posted comments on this change. Change subject: core,restapi,webadmin: Added description field to storage domain ......................................................................
Patch Set 5: I would prefer that you didn't submit this (4 inline comments) Please add some descriptions in fixtures,xml. Some inline comments, nothing major. -1 is given in the meanwhile, until I make sense of the create_views.sql issue (again, inline). Will update with my findings. .................................................... File backend/manager/dbscripts/create_views.sql Line 33: AS Line 34: Line 35: -- TODO: Change code to treat disks values directly instead of through this view. Line 36: SELECT images.image_guid as image_guid, Line 37: storage_domain_static_view.storage_name as storage_name, storage_domain_static_view.storage_description as storage_description, Looks redundant, need to check somemore. Line 38: storage_domain_static_view.storage as storage_path, Line 39: storage_domain_static_view.storage_pool_id as storage_pool_id, Line 40: images.creation_date as creation_date, Line 41: images.size as size, .................................................... File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetStorageDomainsByImageIdQueryTest.java Line 54: 0, Line 55: StorageDomainStatus.Active, Line 56: "StoragePoolName", Line 57: 0, Line 58: 0, "First Storage Description"); Please keep convention - do this in a new line. Line 59: storage_domains secondStorageDomain = Line 60: new storage_domains(Guid.NewGuid(), Line 61: Guid.NewGuid().toString(), Line 62: "SecondStorage", Line 65: 0, Line 66: StorageDomainStatus.Active, Line 67: "StoragePoolName", Line 68: 0, Line 69: 0, "Second Storage Description"); Please keep convention - do this in a new line. Line 70: List<storage_domains> expected = new ArrayList<storage_domains>(); Line 71: expected.add(firstStorageDomain); Line 72: expected.add(secondStorageDomain); Line 73: .................................................... Commit Message Line 6: Line 7: core,restapi,webadmin: Added description field to storage domain Line 8: Line 9: Added a description field to the storage domain entity, changes also made Line 10: to the webadmin and rest to reflect this change s/rest/REST/ Line 11: Line 12: Change-Id: I86bcd7c52e5d9cad7c3cb30561718203537ab459 Line 13: Bug-Url: https://bugzilla.redhat.com/614859 -- To view, visit http://gerrit.ovirt.org/11929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86bcd7c52e5d9cad7c3cb30561718203537ab459 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
