Maor Lipchuk has posted comments on this change.
Change subject: core,restapi,webadmin: Added description field to storage domain
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageDomainStatic.java
Line 23: @ValidName(message =
"VALIDATION.STORAGE_DOMAIN.DESCRIPTION.INVALID", groups = { CreateEntity.class,
Line 24: UpdateEntity.class })
Line 25: @Size(min = 1, max = BusinessEntitiesDefinitions.GENERAL_MAX_SIZE,
message = "VALIDATION.VDS_GROUP.NAME.MAX",
Line 26: groups = { CreateEntity.class, UpdateEntity.class })
Line 27: private String description;
message still not related, also don't you want to add here the
DESCRIPTION.INVALID validation also
Line 28:
Line 29: private StorageDomainType storageType = StorageDomainType.Master;
Line 30:
Line 31: private StorageType storagePoolType = StorageType.UNKNOWN;
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 591: VALIDATION.VDS.CONSOLEADDRESSS.HOSTNAME_OR_IP=Console address must be
a FQDN or a valid IP address
Line 592: VALIDATION.VDS.POWER_MGMT.ADDRESS.HOSTNAME_OR_IP=Host power
management address must be a FQDN or a valid IP address
Line 593: VALIDATION.VM.NUM_OF_MONITORS.EXCEEDED=VM exceeded the number of
allowed monitors
Line 594: VALIDATION.STORAGE_DOMAIN.NAME.INVALID=Storage Domain name must be
formed of "a-z0-9A-Z" or "-_"
Line 595: VALIDATION.STORAGE_DOMAIN.DESCRIPTION.INVALID=Storage Domain
description must be formed of "a-z0-9A-Z" or "-_"
see comment in previous patch
Line 596: VALIDATION.VM_TEMPLATE.NAME.MAX=VM Template name must not exceed 40
characters
Line 597: VALIDATION.DISK_INTERFACE.NOT_NULL=Interface is required
Line 598: VALIDATION.VOLUME_TYPE.NOT_NULL=Volume type is required
Line 599: VALIDATION.DISK_TYPE.NOT_NULL=Disk type is required
--
To view, visit http://gerrit.ovirt.org/11929
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I86bcd7c52e5d9cad7c3cb30561718203537ab459
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
