Allon Mureinik has posted comments on this change. Change subject: core,restapi,webadmin: Added description field to storage domain ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/dbscripts/create_views.sql Line 33: AS Line 34: Line 35: -- TODO: Change code to treat disks values directly instead of through this view. Line 36: SELECT images.image_guid as image_guid, Line 37: storage_domain_static_view.storage_name as storage_name, storage_domain_static_view.storage_description as storage_description, Yes, it's redundent. please remove. Line 38: storage_domain_static_view.storage as storage_path, Line 39: storage_domain_static_view.storage_pool_id as storage_pool_id, Line 40: images.creation_date as creation_date, Line 41: images.size as size, -- To view, visit http://gerrit.ovirt.org/11929 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86bcd7c52e5d9cad7c3cb30561718203537ab459 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
