Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: allow interactive NFS exports cleanup ......................................................................
Patch Set 6: > What about localization of the descriptions? This is nice question.... I am unsure what to reply. I can say that less line of code and less flexibility are more important for me than having localized uninstall... I don't know if you agree with me... But the group name can be taken from gettext, so actually: string = "string1" gettext.dgettext(message=string, domain='ovirt-engine-setup') will work... but gettext will not auto generate the string1 in the translation automatically. So string1 can be translated but need some manual work. -- To view, visit http://gerrit.ovirt.org/14702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16b5920f0cfc9f564aa92f7e0d5a6d33af5e0b44 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
