Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: allow interactive NFS exports cleanup ......................................................................
Patch Set 5: (1 inline comment) Looks good! Apart of the minor comment, now that I see this implementation... I am thinking... What about adding description for each group by setup, and just go over all group and ask the user if he wishes to remove? This will eliminate the need for specifics at the uninstaller, no? We can leave only very complex / backup stuff. What do you think? Alon .................................................... File packaging/setup/plugins/ovirt-engine-remove/files/simple.py Line 68: ) Line 69: def _init(self): Line 70: self.environment.setdefault( Line 71: osetupcons.CoreEnv.UNINSTALL_ENABLED_FILE_GROUPS, Line 72: ['core'] I suggest a string, comma delimited, this will allow to use the environment files to override, as it can only override basic types. Line 73: ) Line 74: Line 75: @plugin.event( Line 76: stage=plugin.Stages.STAGE_MISC, -- To view, visit http://gerrit.ovirt.org/14702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16b5920f0cfc9f564aa92f7e0d5a6d33af5e0b44 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
