Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: allow interactive NFS exports cleanup
......................................................................
Patch Set 7: (5 inline comments)
Thanks!
Looks good! few more...
....................................................
File packaging/setup/plugins/ovirt-engine-remove/files/simple.py
Line 117: if msg == template:
Line 118: msg = description
Line 119: self._descriptions[group] = msg
Line 120: add_group = True
Line 121: if config.getboolean(section, 'optional'):
I suggest something like:
add_group = not config.getboolean(section, 'optional)
if not add_group and interactive:
# ask
Line 122: add_group = False
Line 123: if interactive:
Line 124: add_group = dialog.queryBoolean(
Line 125: dialog=self.dialog,
Line 153: x.strip()
Line 154: for x in self.environment[
Line 155: osetupcons.CoreEnv.UNINSTALL_ENABLED_FILE_GROUPS
Line 156: ].split(',')
Line 157: if x
my bad... we need x.strip() here as well... to support 'a,x,,d')
Line 158: ]:
Line 159: self._files.update(
Line 160: getFiles(
Line 161: osetupcons.Const.FILE_GROUP_SECTION_PREFIX +
....................................................
File packaging/setup/plugins/ovirt-engine-setup/core/uninstall.py
Line 47: []
Line 48: )
Line 49: self.config[group] = {}
Line 50: self.config[group]['description'] = description
Line 51: self.config[group]['optional'] = optional
I suggest to add:
return self
So it can be possible to do:
xxx.createGroup().addFiles()
:)
Line 52:
Line 53: def addFiles(self, group, fileList):
Line 54: self.environment[
Line 55: osetupcons.CoreEnv.FILE_GROUP_PREFIX + group
Line 52:
Line 53: def addFiles(self, group, fileList):
Line 54: self.environment[
Line 55: osetupcons.CoreEnv.FILE_GROUP_PREFIX + group
Line 56: ].append(fileList)
are you sure append and not extend?
Line 57:
Line 58:
Line 59: @util.export
Line 60: class Plugin(plugin.PluginBase):
....................................................
File packaging/setup/plugins/ovirt-engine-setup/system/exportfs.py
Line 94: stage=plugin.Stages.STAGE_MISC,
Line 95: condition=lambda self: self._enabled,
Line 96: after=[
Line 97: osetupcons.Stages.CONFIG_ISO_DOMAIN_AVAILABLE
Line 98: ]
missing , at suffix
Line 99: )
Line 100: def _misc(self):
Line 101: """
Line 102: Assume that if /etc/exports.d exists we have exports.d
support.
--
To view, visit http://gerrit.ovirt.org/14702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I16b5920f0cfc9f564aa92f7e0d5a6d33af5e0b44
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
