Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: allow interactive NFS exports cleanup ......................................................................
Patch Set 7: (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/core/uninstall.py Line 52: Line 53: def addFiles(self, group, fileList): Line 54: self.environment[ Line 55: osetupcons.CoreEnv.FILE_GROUP_PREFIX + group Line 56: ].append(fileList) Just to make sure... why calling 2 times with 2 lists is different than calling one time with one line that contain the above two? Line 57: Line 58: Line 59: @util.export Line 60: class Plugin(plugin.PluginBase): -- To view, visit http://gerrit.ovirt.org/14702 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16b5920f0cfc9f564aa92f7e0d5a6d33af5e0b44 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
