On 04/14/11 07:36, Claudio Valderrama C. wrote:
>> -----Original Message-----
>> From: Alex Peshkoff [mailto:peshk...@mail.ru]
>> Sent: Miércoles, 13 de Abril de 2011 9:07
>> To: For discussion among Firebird Developers
> ....
>> void fini()
>> {
>> if (bufferLength)
>> {
>> buffer = new unsigned char[bufferLength];
>> }
>> }
> I really do not like this method's name. It wasn't until I read the
> following lines that I realized what it does:
>
>> Usage is:
> ....
>> msg.blr = blr;
>> msg.blrLength = sizeof(blr);
>> msg.fini();
>> // Finished with message prepare
> What is the reason a word like "prepare" wasn't used instead? For me, "fini"
> looks like something that's invoked by the destructor.
>
Agreed.
This was not more than a temporary working materials, I think this place
of code will change many times, even if it will get sometimes in the tree.
>> while (state->fetch(s, &msg) == 0)
>> {
>> checkStatus(s);
>> // printf("%d\n", msg[i1]);
>> }
> And probably it would help if we introduce named constants for the return
> values produced by fetch().
>
Here completely agreed.
Will do.
------------------------------------------------------------------------------
Benefiting from Server Virtualization: Beyond Initial Workload
Consolidation -- Increasing the use of server virtualization is a top
priority.Virtualization can reduce costs, simplify management, and improve
application availability and disaster protection. Learn more about boosting
the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev
Firebird-Devel mailing list, web interface at
https://lists.sourceforge.net/lists/listinfo/firebird-devel
