On 9 Dec 2012, at 19:22, Adrian Musceac <kanto...@gmail.com> wrote:

> PS: is there anyone willing to check my new radio code in before the feature 
> freeze, even disabled at all, or do I have to wait until next summer? I'd 
> appreciate an honest answer.

I did a review of the code, but was travelling all last week with very erratic 
Internet access. My feeling is the code is not suitable to be merged as-is, due 
to serious structural issues. (Unrelated to the actual simulation math, which 
looks plausible but is beyond my expertise). 

In particular the way the code is using subsystems and properties seems very 
strange to me. My proposal is, I'll take your patch as inspiration, and write a 
dummy version which does a no-op simulation, but which interacts with the radio 
code in a way I think fits with the rest of the sim. Once I've done that, you 
can convert your functional code to fit that structure, and it can be merged. 

Hope that sounds reasonable. 

James

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel

Reply via email to