> -----Original Message----- > From: Jeremias Maerki [mailto:[EMAIL PROTECTED] > > Committers, I don't see a problem with what Nils proposes. Does anyone > else? If not, I can do the change next week. If Nils already has a patch > for us, even better. :-) >
Well, the whole idea behind using interned strings and the == operator is speed. As you both are probably well aware, using .equals() on interned strings is a lot slower than comparing them with ==. It may affect 'only' 30 types, but of these types, many can have an unlimited number of instances or children --think of fo:block/fo:inline...-- so this means that such comparisons could be made hundreds (maybe even thousands) of times. I guess for large FO documents, the change proposed *will* mean a drop in performance speed-wise. I'm not sure whether it will be noticeable on today's hardware, but based on the above I personally would really prefer it if Nils looked for a way to intern the namespace URI strings to make it possible to use ==. Just my 2 cents. If there are other committers that don't see a problem changing the code, I won't veto the change though... Cheers, Andreas
