Adrian Cumiskey wrote: > Hi all, > > Maybe its time we moved to 1.5 like the rest of the world. Max, Vincent > and Andreas, myself and others were all in favour of the switch in June > 2008 (see http://www.nabble.com/Switching-to-Java-1.5-td17673100.html). > Sun's end of life transition period for 1.4 ended on October 30th, > 2008. I personally think we can now safely retroweave to 1.4.
+1 Although we don’t even need to discuss that in the context of Simon’s change, IMO. Like the comment says in the build.xml file, the task doesn’t need to be run at every build. So 1.4 compatibility still is available. OTOH, the new UnicodeClasses class has quite a few checkstyle warnings that it would be good if they were fixed. Also, I have concerns about putting the generated classes.xml file inside the src/java directory. I’d rather not mix generated files with manually edited ones. What about a new hyphenation directory in src/codegen? Thanks, Vincent > Adrian. > > Jeremias Maerki wrote: >> Uhm, Simon, this change uses tons of Java 1.5 features. The build fails >> now on Java 1.4. OK if we revert until you've had a chance to revisit? >> >> On 18.08.2009 22:05:01 spepping wrote: >> >>> Author: spepping >>> Date: Tue Aug 18 20:05:01 2009 >>> New Revision: 805561 >>> >>> URL: http://svn.apache.org/viewvc?rev=805561&view=rev >>> Log: >>> Prepare for new hyphenation pattern files, which do not have their >>> own classes and instead use the default classes in FOP. Modified the >>> build process to a forked java task, in order to be able to set a >>> larger stack size for the compilation of the large number of classes. >>> Added an ant task to generate a new default classes file, to be used >>> with an update of the Unicode Character Database. >>> >>> Added: >>> >>> xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/SerializeHyphPattern.java >>> >>> (with props) >>> >>> xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/UnicodeClasses.java >>> >>> (with props) >>> >>> xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/classes.xml >>> (with props) >>> Removed: >>> >>> xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/SerializeHyphPattern.java >>> >>> Modified: >>> xmlgraphics/fop/trunk/build.properties >>> xmlgraphics/fop/trunk/build.xml >>> >>> xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/PatternParser.java >>> >>> >>> >> >> >> >> Jeremias Maerki