There we go again. ;-) I can understand the wishes and cravings of the
developers (feeling them myself), but as I've said before: such a
decision should be made with the user community in the back, i.e. there
should be another user survey to gather current data. Just because Sun
EOLs a Java version doesn't mean that everyone can suddenly just do the
switch. So why don't those who want this change so badly do that little
survey so we have the data on an informed decision?

As for retroweaving: I've just set the necessary values in my
build-local.properties and tried to compile the latest FOP Trunk with
Java 1.5. The build failed in the retroweaver task:

-----------------------------------------------------------------------

retro-avail:
    [mkdir] Created dir: C:\Dev\FOP\main\trunk-clean2\build\temp
[retroweaver] Processing 1775 classes
[retroweaver] 1775 classes weaved.
[retroweaver] Verifying 1775 classes
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
isLowerCase/(I)Z, The class, 
net.sourceforge.retroweaver.runtime.java.lang.Character_, c
ould not be located: net/sourceforge/retroweaver/runtime/java/lang/Character_
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
isUpperCase/(I)Z, The class, 
net.sourceforge.retroweaver.runtime.java.lang.Character_, c
ould not be located: net/sourceforge/retroweaver/runtime/java/lang/Character_
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
isTitleCase/(I)Z, Method not found in java.lang.Character
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
toLowerCase/(I)I, Method not found in java.lang.Character
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
getType/(I)I, Method not found in java.lang.Character
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
of/(I)Ljava.lang.Character$UnicodeBlock;, Method not found in 
java.lang.Character$Unicod
eBlock
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
toUpperCase/(I)I, Method not found in java.lang.Character
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
toTitleCase/(I)I, Method not found in java.lang.Character
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
toChars/(I)[C, The class, 
net.sourceforge.retroweaver.harmony.runtime.java.lang.Characte
r_, could not be located: 
net/sourceforge/retroweaver/harmony/runtime/java/lang/Character_
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
toChars/(I)[C, The class, 
net.sourceforge.retroweaver.harmony.runtime.java.lang.Characte
r_, could not be located: 
net/sourceforge/retroweaver/harmony/runtime/java/lang/Character_
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
toChars/(I)[C, The class, 
net.sourceforge.retroweaver.harmony.runtime.java.lang.Characte
r_, could not be located: 
net/sourceforge/retroweaver/harmony/runtime/java/lang/Character_
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
toChars/(I)[C, The class, 
net.sourceforge.retroweaver.harmony.runtime.java.lang.Characte
r_, could not be located: 
net/sourceforge/retroweaver/harmony/runtime/java/lang/Character_
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
toChars/(I)[C, The class, 
net.sourceforge.retroweaver.harmony.runtime.java.lang.Characte
r_, could not be located: 
net/sourceforge/retroweaver/harmony/runtime/java/lang/Character_
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
toChars/(I)[C, The class, 
net.sourceforge.retroweaver.harmony.runtime.java.lang.Characte
r_, could not be located: 
net/sourceforge/retroweaver/harmony/runtime/java/lang/Character_
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
toChars/(I)[C, The class, 
net.sourceforge.retroweaver.harmony.runtime.java.lang.Characte
r_, could not be located: 
net/sourceforge/retroweaver/harmony/runtime/java/lang/Character_
[retroweaver] org.apache.fop.hyphenation.UnicodeClasses: unknown method 
toChars/(I)[C, The class, 
net.sourceforge.retroweaver.harmony.runtime.java.lang.Characte
r_, could not be located: 
net/sourceforge/retroweaver/harmony/runtime/java/lang/Character_
[retroweaver] org.apache.fop.pdf.PDFEncryptionJCE$EncryptionFilter: unknown 
class javax.crypto.CipherOutputStream
[retroweaver] org.apache.fop.pdf.PDFEncryptionJCE: unknown method 
doFinal/([B)[B, The class, javax.crypto.Cipher, could not be located: 
javax/crypto/Cipher
[retroweaver] org.apache.fop.pdf.PDFEncryptionJCE: unknown method 
getMessage/()Ljava.lang.String;, The class, 
javax.crypto.IllegalBlockSizeException, could not
be located: javax/crypto/IllegalBlockSizeException
[retroweaver] org.apache.fop.pdf.PDFEncryptionJCE: unknown method 
getMessage/()Ljava.lang.String;, The class, javax.crypto.BadPaddingException, 
could not be loc
ated: javax/crypto/BadPaddingException
[retroweaver] org.apache.fop.pdf.PDFEncryptionJCE: unknown class 
javax.crypto.Cipher
[retroweaver] org.apache.fop.pdf.PDFEncryptionJCE: unknown class 
javax.crypto.IllegalBlockSizeException
[retroweaver] org.apache.fop.pdf.PDFEncryptionJCE: unknown class 
javax.crypto.BadPaddingException
[retroweaver] org.apache.fop.pdf.PDFEncryptionJCE: unknown class 
javax.crypto.spec.SecretKeySpec
[retroweaver] org.apache.fop.pdf.PDFEncryptionJCE: unknown method 
getMessage/()Ljava.lang.String;, The class, 
javax.crypto.NoSuchPaddingException, could not be
located: javax/crypto/NoSuchPaddingException
[retroweaver] org.apache.fop.pdf.PDFEncryptionJCE: unknown class 
javax.crypto.Cipher
[retroweaver] org.apache.fop.pdf.PDFEncryptionJCE: unknown class 
javax.crypto.spec.SecretKeySpec
[retroweaver] org.apache.fop.pdf.PDFEncryptionJCE: unknown class 
javax.crypto.NoSuchPaddingException
[retroweaver] Verification complete, 28 warning(s).

BUILD FAILED
C:\Dev\FOP\main\trunk-clean2\build.xml:519: 28 warning(s)

-----------------------------------------------------------------------

So that seems to indicate that the retroweaver business is not as simple
as it sounds. Furthermore, has anyone done any serious tests in a
non-trivial environment (for example an enterprise-level application
running in an app server)? Maybe one of the stake holders around here
that still need to support a Java 1.4 environment can do such a test and
report back here?

Don't get me wrong: I don't want to block this but I want this done on
an informed basis and with a vote, not just because the developers like
generics. That's reasonable, isn't it?

On 19.08.2009 19:28:25 Vincent Hennebert wrote:
> Adrian Cumiskey wrote:
> > Hi all,
> > 
> > Maybe its time we moved to 1.5 like the rest of the world.  Max, Vincent
> > and Andreas, myself and others were all in favour of the switch in June
> > 2008 (see http://www.nabble.com/Switching-to-Java-1.5-td17673100.html). 
> > Sun's end of life transition period for 1.4 ended on October 30th,
> > 2008.  I personally think we can now safely retroweave to 1.4.
> 
> +1
> 
> Although we don’t even need to discuss that in the context of Simon’s
> change, IMO. Like the comment says in the build.xml file, the task
> doesn’t need to be run at every build. So 1.4 compatibility still is
> available.
> 
> OTOH, the new UnicodeClasses class has quite a few checkstyle warnings
> that it would be good if they were fixed.
> 
> Also, I have concerns about putting the generated classes.xml file
> inside the src/java directory. I’d rather not mix generated files with
> manually edited ones. What about a new hyphenation directory in
> src/codegen?
> 
> 
> Thanks,
> Vincent
> 
> 
> > Adrian.
> > 
> > Jeremias Maerki wrote:
> >> Uhm, Simon, this change uses tons of Java 1.5 features. The build fails
> >> now on Java 1.4. OK if we revert until you've had a chance to revisit?
> >>
> >> On 18.08.2009 22:05:01 spepping wrote:
> >>  
> >>> Author: spepping
> >>> Date: Tue Aug 18 20:05:01 2009
> >>> New Revision: 805561
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=805561&view=rev
> >>> Log:
> >>> Prepare for new hyphenation pattern files, which do not have their
> >>> own classes and instead use the default classes in FOP. Modified the
> >>> build process to a forked java task, in order to be able to set a
> >>> larger stack size for the compilation of the large number of classes.
> >>> Added an ant task to generate a new default classes file, to be used
> >>> with an update of the Unicode Character Database.
> >>>
> >>> Added:
> >>>    
> >>> xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/SerializeHyphPattern.java
> >>>   
> >>> (with props)
> >>>    
> >>> xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/UnicodeClasses.java
> >>>   
> >>> (with props)
> >>>    
> >>> xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/classes.xml  
> >>> (with props)
> >>> Removed:
> >>>    
> >>> xmlgraphics/fop/trunk/src/java/org/apache/fop/tools/anttasks/SerializeHyphPattern.java
> >>>
> >>> Modified:
> >>>     xmlgraphics/fop/trunk/build.properties
> >>>     xmlgraphics/fop/trunk/build.xml
> >>>    
> >>> xmlgraphics/fop/trunk/src/java/org/apache/fop/hyphenation/PatternParser.java
> >>>
> >>>
> >>>     
> >>
> >>
> >>
> >> Jeremias Maerki




Jeremias Maerki

Reply via email to