Thanks to your advice (and my finding the checkstyle configurator in
Idea) I'm now using checkstyle-5.0.xml from FOP. Thank you very much!
However, I notice there are still warnings.
BlockStackingLayoutManager.java: 16 items
Missing a Javadoc comment. (58:5)
'parentArea' hides a field. (115:47)
'parentArea' hides a field. (145:50)
Method length is 185 lines (max allowed is 150) (372:5)
Etc.,
I'm using JetBrains IDEA 8.1.3.
Is the rule we ignore warnings and only look for errors?
BTW, I got Checkstyle to work in IDEA by changing checkstyle-5.0.xml in
FOP in the following way:
<module name="RegexpHeader">
<property name="headerFile"
value="c:/perforce/Users/levinson/fop-trunk/checkstyle.header"/>
Thanks again for your help!,
Jonathan S. Levinson
Senior Software Developer
Object Group
InterSystems
-----Original Message-----
From: Alexander Kiel [mailto:alexanderk...@gmx.net]
Sent: Sunday, September 27, 2009 4:55 PM
To: fop-dev@xmlgraphics.apache.org
Subject: Re: Confused about checkstyle use
Hi Jonathan,
did you use the checkstyle-5.0.xml from FOP or the default SUN profile?
I'm currently not able to start IDEA, but two days ago as I downloaded
the plugin, I noticed that the SUn profile was active and I had to
define the FOP profile. And if you define the FOP profile, you will
properly notice that the header thing did not work. Its a path inclusion
problem of the header.* file. I did not have a solution for it, I just
commended it out for now.
Best Regards
Alex
Jonathan Levinson wrote:
>
> I've installed the Checkstyle plugin for IDEA and the current code
> when scanned by the plugin shows lots of Checkstyle errors.
>
> Here are some errors scanning BlockStackingLayoutManager.java:
>
> Missing package-info.java file (0:0)
>
> Line is longer than 80 characters. (18:0)
>
> First sentence should end with a period (53:0)
>
> Variable 'bpUnit' must be private and have accessor methods. (61:19)
>
> What does it mean to have clean code according to "Checkstyle"?
>
> Is my plugin misconfigured? Is it by default at too strict a setting?
>
> Best Regards,
>
> Jonathan S. Levinson
>
> Senior Software Developer
>
> Object Group
>
> InterSystems
>
