Not all FOP developers are willing to use findbugs. I hid the findbugs errors as a courtesy to those FOP developers who do use findbugs, so they can check their own code based on a clean slate.
FOP's history has left us with a very large number of existing findbugs errors. It makes no sense to comment on that; it is a fact of life. FOP's code first of all does a good job at being a successful, heavily used FO processor. Only after that comes the question of a clean code base. That said, of course every FOP developer and every FOP user is welcome to evaluate and possibly remedy one or more findbugs errors. For precisely that reason I put comments in the exclusion file, so one can see which errors have been simply hidden and which have been truely evaluated. Simon On Mon, Feb 21, 2011 at 06:15:13PM +0000, Vincent Hennebert wrote: > Hi, > > If we solve issues raised by FindBugs by listing them in an ignore file, > is there still a point to use FindBugs at all? > > It seems to me that some of those issues deserve to be fixed. They seem > to point out genuine problems in the code. > > Vincent > > > On 18/02/11 08:18, spepp...@apache.org wrote: > > Author: spepping > > Date: Fri Feb 18 08:18:04 2011 > > New Revision: 1071912 > > > > URL: http://svn.apache.org/viewvc?rev=1071912&view=rev > > Log: > > Fixing checkstyle errors and hiding fingbugs errors > > > > Modified: > > xmlgraphics/fop/trunk/findbugs-exclude.xml > > > > xmlgraphics/fop/trunk/src/java/org/apache/fop/render/pdf/PDFImageHandlerSVG.java > > > > Modified: xmlgraphics/fop/trunk/findbugs-exclude.xml > > URL: > > http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/findbugs-exclude.xml?rev=1071912&r1=1071911&r2=1071912&view=diff
