Thank you FOP team. As I have stated previously, I am prepared to improve and maintain this code moving forward, including adding comments for local variables not already described, and refactoring certain classes to reduce class size.
I've also given some thought to moving the new CS classes in o.a.f.fonts into a new subpackage: org.apache.fop.fonts.complexscripts It may also be possible to refactor the new ATT parsing support I added to o.a.f.fonts.truetype.TTFFile into separate files as well. Frankly, though, I wonder if the entire font subsystem isn't in need of a redesign. It seems to be overly complex and unwieldy even without the new CS features. I may also refactor BidiUtil and move into a new subpackage: org.apache.fop.layoutengine.bidi Regarding o.a.f.complexscripts.util.TTXFile, this is a utility class used only with certain junit related test files. At present, checkstyle is not even run on *any* of the junit related java source files. Length of this file or its methods or number of field declarations should not an issue. If someone wants to refactor that file as an exercise for the reader, I have no objection. Let me know how I may most expeditiously accomplish this work. In the mean time, I will prepare a patch against trunk from the Temp_CS branch, which I imagine Simon will be the one to apply. G. On Sat, Oct 29, 2011 at 2:05 AM, Simon Pepping <[email protected]>wrote: > Seven committers voted. There were five +1 votes and no -1 votes. There > was one -0.9 vote and one -0 vote. > > According to the Project Charter three +1 ('yes' votes) with no -1 > ('no' votes or vetoes) are needed to approve a significant code > change. Therefore the proposal to merge the Temp_ComplexScripts branch > into trunk has been accepted. > > Thank you for voting. I acknowledge that Vincent and Peter are not > convinced of the wisdom of this decision. I hope we can all move > forward with this new situation. > > Simon > > On Tue, Oct 25, 2011 at 10:31:43AM +0200, Simon Pepping wrote: > > With his latest patch, Glenn Adams wrote: > > > > With this latest patch I am satisfied that there is sufficient testing > and > > stability in the CS branch to support its merger into trunk. Therefore, I > > request that such a merge be accomplished after applying patch 5 to the > CS > > branch. > > > > ... snip ... > > > > Note that there remains work to be done on CS support, including adding > > support for: > > > > - additional scripts > > - additional output formats > > > > At present, support is provided for: > > > > - Arabic, Hebrew, and Devanagari Scripts > > - PDF output format > > > > I expect that additional support for other scripts and formats will be > added > > over time, either by myself, or other members of the community. However, > the > > absence of support for all complex scripts and all output formats should > not > > be a deterrent to active use of the support already present. It is now a > > good time to broaden the user community of the CS features, and the best > way > > to do that is to bring it into the trunk at this time. > > > > End of quote > > > > Following this request, I herewith propose to merge the branch > > Temp_ComplexScripts into trunk, and launch a formal vote. > > > > I vote positive: +1 > > > > For the rules of voting about code commits, see the project charter, > > article 11, http://wiki.apache.org/xmlgraphics/ProjectCharter. > > > > Simon Pepping >
