Update of bug #16065 (project freeciv):

                  Status:                    None => Ready For Test         
             Assigned to:                    None => syntron                
         Planned Release:                         => 2.3.0                  

    _______________________________________________________

Follow-up Comment #3:

I did checked all the calls to the function; here my analysis:

flags for find_closest_city():
  bool only_ocean
  bool only_continent
  bool only_known
  bool only_player
  bool only_enemy

calls to this function:

- ai/aidiplomat.c
=> ai_manage_diplomat(): diplomat searching a save home (10010)
- ai/aiunit.c
=> ai_military_defend(): unit searching a city to defend (0?010); ? =
is_ground_unit()
=> ai_military_attack_barbarian(): barbarians searching a target (0?001); ? =
!(unit in transport)
- server/barbarians.c
=> try_summon_barbarians(): find a city to attack (00000)
- server/cityturn.c
=> disband_city() and do_city_migration(): closest city to rehome units
(00010)
- server/diplomats.c
=> diplomat_escape(): closest city for escape (00010)
- server/edithand.c
=> handle_edit_unit_create(): homecity for new unit (?0010); ? =
is_sailing_unit()
- server/unittools.c
=> wipe_unit(): save home for undisbandable units (10010)

So 'only_known' is never used ...

If somebody could please check this analysis?

(file #9310)
    _______________________________________________________

Additional Item Attachment:

File name: 20100612-02-trunk-fix-find_closest_city.patch Size:4 KB


    _______________________________________________________

Reply to this item at:

  <http://gna.org/bugs/?16065>

_______________________________________________
  Nachricht geschickt von/durch Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to