Follow-up Comment #1, patch #3775 (project freeciv):
I'm not sure that anything that relies on uclass_move_type() is a reliable
mechanism to use to determine if a potential bodyguard can properly protect a
potential charge. This only checks whether some of the native terrains for
the unit happen to be of class "Land" or class "Oceanic", but doesn't check to
see if the potential bodyguard can actually enter all the terrains the charge
can enter (as an example, one could define a UMT_LAND unit that could use
every land terrain, and a UMT_BOTH unit that could only use coastal ocean,
rivers, and swamps, making the UMT_BOTH unit a poor guard for the charge).
Aside from terrain checks, units with fuel or hp_loss restrictions may also be
of limited use as bodyguards for units without such restrictions, as they will
be constantly retreating to base (this may be part of why UMT_BOTH units
historically don't pass this test).
Reply to this item at:
Message sent via/by Gna!
Freeciv-dev mailing list