Follow-up Comment #10, bug #22050 (project freeciv):

>> Before this fix, had the check been effective, it would have
>> completely prevented Helicopters and Carriers from ever being
>> on each other, but Helicopters could have carried Dinghies.
>> It's as if a complex system of unit classes had been set up to
>> exclude this nesting.
>> (As it is, the 'forbidden' nesting will be allowed at
>> UNIT_LOAD time, but will cause sanity-check grumbling later.)
> If I understood correctly, it was allowing (even in
> sanity-check) Helicopters loaded onto Carriers and Carriers
> onto Helicopters.

I checked again, I think I misunderstood this piece of code. Thank you for
having pointed it to me. I will rewrite unit_transport_check() to prevent
cargo to be able to load on of its upper-level transport.

>> I think at least some of these fixes should go to S2_4.
> I will try to propose a patch for it then.

After reflexion, I think the whole patch should be ported to S2_4. Anyone


Reply to this item at:


  Message posté via/par Gna!

Freeciv-dev mailing list

Reply via email to