URL: https://github.com/freeipa/freeipa/pull/84 Title: #84: Fix update_from_dict function testing
jcholast commented: """ @abbra: > Update plugins are higher level of abstraction. They use > ipaserver.install.ldapupdate.LDAPUpdate which provides both .update() and > .update_from_dict() methods. Update plugins can produce dictionaries. With > the change in this pull request they will have to always write down dynamic > update content to files first and then run LDAPUpdate.update() with those > files. Or re-implement .update_from_dict(). This is not true, update plugins are supposed to return the dictionaries from their `execute` method. See any of the update plugins in [ipaserver/install/plugins](https://github.com/freeipa/freeipa/tree/master/ipaserver/install/plugins) for how it's done. """ See the full comment at https://github.com/freeipa/freeipa/pull/84#issuecomment-248579978
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
