URL: https://github.com/freeipa/freeipa/pull/317
Title: #317: Unify password generation across FreeIPA

pspacek commented:
"""
Guys, I'm confused. What exactly is the purpose of `TokenGenerator`? The 
docstring does not explain to me what is relation between arguments in 
`__init__` and `__call__`. Of course I can guess but this should be clearly 
defined first.

If we are clever enough we can get away with the `while` loop and make it 
deterministic.
"""

See the full comment at 
https://github.com/freeipa/freeipa/pull/317#issuecomment-266030088
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to