On Tue, May 7, 2013 at 1:46 PM, Patrick Strasser
<[email protected]>wrote:
> schrieb Richard Shaw on 2013-05-07 14:22:
>
> > Theoretically, yes. The only problem with testing this right now is if
> > your build depends on config.h, it may not be able to find it until
> > fdmdv2_main.h is updated because cmake prefers, and I've enforced
> > out-of-source builds so my config.h is getting generated in the binary
> > dir instead of the source dir where fdmdv2_main.h is pointing.
> >
> > If you want to test it I would recommend making a copy of the source
> > manually or with "svn export ...". and manually removing the "../" ah
> la:
> >
> > #include "../config.h"
> > to
> > #include "config.h"
>
> Is this the normal process in cmake to define HAVE_CONFIG_H and provide
> config.h? I though HAVE_CONFIG_H is an autotools thing. But in both
> cases out of tree building is a fine thing, which leads to the situation
> that at build time the config.h from the build directory has to be known
> to the source. Having a path prefix at the include makes that kind of
> tricky. Except of course the source is copied to the build directory.
>
No, it's not typical of a cmake project but I'm not touching the source
code, only creating the cmake configuration. It doesn't cost much (it's
already done and takes no time to generate) and if I remember correctly it
having all the defines in config.h may be helpful for some development
environments (MSVC?)
Now that being said, in all of check inspections I made, the source code
doesn't seem to do anything useful with the definitions (i.e.: If HAVE_X is
available, use X, otherwise use Y method).
If we decide they are not needed (on either autotools or cmake) we can
remove them, but for the time being, I'm implementing the cmake config in a
"don't rock the boat" manner.
Thanks,
Richard
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and
their applications. This 200-page book is written by three acclaimed
leaders in the field. The early access version is available now.
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________
Freetel-codec2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freetel-codec2
