schrieb Richard Shaw on 2013-05-07 22:05:
> Now that being said, in all of check inspections I made, the source code
> doesn't seem to do anything useful with the definitions (i.e.: If HAVE_X
> is available, use X, otherwise use Y method).
When I worked on using autoconf end of last year I did not clean up all
the config.h stuff, just threw it in as one of the parts that
auto{conf,make,header} wanted to have. It should be only useful for
autoconf and friends, and even then I think most of the defines are not
really carefully checked. I think most of the proposed checks for
autoconf are related to a Windows build, which I did not care of any way.
> If we decide they are not needed (on either autotools or cmake) we can
> remove them, but for the time being, I'm implementing the cmake config
> in a "don't rock the boat" manner.
I understand. In this case, the config.h-defines are nearly orthogonal,
but still they should be corrected. The code does not ship an config.h,
which means you have to compile with _NO_AUTOTOOLS_ or compilation will
fail. This is not so good.
A little more structured:
* The code currently needs _NO_AUTOTOOLS_ defined, unless config.h is
present.
* config.h is only generated by autotools, which would define
HAVE_CONFIG_H in that case.
* CMake creates a config.h that contains sensible defines.
* None of the defines is used in the src directory. Not sure about SIZE_INT.
* The logic for including config.h is reversed, which forces all
non-autoconf-builds to do something to get to build.
I think you can build without config.h and define _NO_AUTOTOOLS_.
Moreover I think the check for config.h should really be changed.
Patrick
--
Engineers motto: cheap, good, fast: choose any two
Patrick Strasser <patrick at wirklich priv at>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and
their applications. This 200-page book is written by three acclaimed
leaders in the field. The early access version is available now.
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________
Freetel-codec2 mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/freetel-codec2
